From: Justin Tobler Date: Wed, 08 Apr 2026 21:05:10 GMT Subject: Re: [PATCH 02/16] odb/source-inmemory: implement `free()` callback Message-ID: In-Reply-To: <20260403-b4-pks-odb-source-inmemory-v1-2-8b8d1abaa25e@pks.im> On 26/04/03 08:01AM, Patrick Steinhardt wrote: > @@ -1126,12 +1115,6 @@ void odb_free(struct object_database *o) > odb_close(o); > odb_free_sources(o); > > - for (size_t i = 0; i < o->inmemory_objects->objects_nr; i++) > - free((char *) o->inmemory_objects->objects[i].value.buf); > - free(o->inmemory_objects->objects); > - free(o->inmemory_objects->base.path); > - free(o->inmemory_objects); Ah ok, this addresses a comment in the previous patch. > - > string_list_clear(&o->submodule_source_paths, 0); > > free(o); > diff --git a/odb/source-inmemory.c b/odb/source-inmemory.c > index c7ac5c24f0..ccbb622eae 100644 > --- a/odb/source-inmemory.c > +++ b/odb/source-inmemory.c > @@ -1,6 +1,16 @@ > #include "git-compat-util.h" > #include "odb/source-inmemory.h" > > +static void odb_source_inmemory_free(struct odb_source *source) > +{ > + struct odb_source_inmemory *inmemory = odb_source_inmemory_downcast(source); > + for (size_t i = 0; i < inmemory->objects_nr; i++) > + free((char *) inmemory->objects[i].value.buf); > + free(inmemory->objects); > + free(inmemory->base.path); > + free(inmemory); > +} > + > struct odb_source_inmemory *odb_source_inmemory_new(struct object_database *odb) > { > struct odb_source_inmemory *source; > @@ -8,5 +18,7 @@ struct odb_source_inmemory *odb_source_inmemory_new(struct object_database *odb) > CALLOC_ARRAY(source, 1); > odb_source_init(&source->base, odb, ODB_SOURCE_INMEMORY, "source", false); > > + source->base.free = odb_source_inmemory_free; We wire up a function to specifically handle freeing the inmemory ODB source. Looks good. -Justin