From: Patrick Steinhardt Date: Fri, 27 Mar 2026 07:07:14 GMT Subject: Re: [PATCH v3 0/6] backfill: accept revision arguments Message-ID: In-Reply-To: On Thu, Mar 26, 2026 at 03:14:48PM +0000, Derrick Stolee via GitGitGadget wrote: > 6: 9699650aa7 ! 6: b6423f9595 t5620: test backfill's unknown argument handling > @@ Commit message > > Before the recent changes to parse rev-list arguments inside of 'git > backfill', the builtin would take arbitrary arguments without complaint (and > - ignore them). This was noticed and a patch was sent [1] which motivates this > - change to encode this behavior in test. > + ignore them). This was noticed and a patch was sent [1] which motivates > + this change. > > [1] https://lore.kernel.org/git/20260321031643.5185-1-r.siddharth.shrimali@gmail.com/ > > + Note that the revision machinery can output an "ambiguous argument" > + warning if a value not starting with '--' is found and doesn't make > + sense as a reference or a pathspec. For unrecognized arguments starting > + with '--' we need to add logic into builtin/backfill.c to catch leftover > + arguments. > + > Reported-by: Siddharth Shrimali > Signed-off-by: Derrick Stolee > > + ## builtin/backfill.c ## > +@@ builtin/backfill.c: int cmd_backfill(int argc, const char **argv, const char *prefix, struct reposit > + repo_init_revisions(repo, &ctx.revs, prefix); > + argc = setup_revisions(argc, argv, &ctx.revs, NULL); > + > ++ if (argc > 1) > ++ die(_("unrecognized argument: %s"), argv[1]); > ++ > + repo_config(repo, git_default_config, NULL); > + > + if (ctx.sparse < 0) > + > ## t/t5620-backfill.sh ## I would've expected this chunk to already come in patch 3, but that alone isn't really worth a reroll. All the other changes look good to me, thanks! Patrick