From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 24 Mar 2026 08:38:12 GMT
Subject: Re: [PATCH v2 10/10] hook: show disabled hooks in "git hook list"
Message-ID: <acJNdKyz-ISsq4fJ@pks.im>
In-Reply-To: <20260320115211.177351-11-adrian.ratiu@collabora.com>

On Fri, Mar 20, 2026 at 01:52:11PM +0200, Adrian Ratiu wrote:
> diff --git a/hook.c b/hook.c
> index aa08c38c27..0e09b9a2bb 100644
> --- a/hook.c
> +++ b/hook.c
> @@ -119,6 +119,7 @@ static void list_hooks_add_default(struct repository *r, const char *hookname,
>  struct hook_config_cache_entry {
>  	char *command;
>  	enum config_scope scope;
> +	unsigned int disabled:1;
>  };
>  
>  /*

Curious, this is now a single-bit int. I still would have expected a
proper bool here :)

> diff --git a/hook.h b/hook.h
> index 92e9faf9bb..7c8c3d471e 100644
> --- a/hook.h
> +++ b/hook.h
> @@ -31,6 +31,7 @@ struct hook {
>  			const char *friendly_name;
>  			const char *command;
>  			enum config_scope scope;
> +			unsigned int disabled:1;
>  		} configured;
>  	} u;

Same here, I would expect a proper bool.

Patrick