From: Patrick Steinhardt Date: Tue, 24 Mar 2026 07:59:05 GMT Subject: Re: [PATCH v2 3/6] backfill: accept revision arguments Message-ID: In-Reply-To: <610a162973a7ad59eba4ef4d5a9288f1fea1d2e8.1774266019.git.gitgitgadget@gmail.com> On Mon, Mar 23, 2026 at 11:40:16AM +0000, Derrick Stolee via GitGitGadget wrote: > diff --git a/builtin/backfill.c b/builtin/backfill.c > index e80fc1b694..90c9d84793 100644 > --- a/builtin/backfill.c > +++ b/builtin/backfill.c > @@ -134,7 +135,12 @@ int cmd_backfill(int argc, const char **argv, const char *prefix, struct reposit > builtin_backfill_usage, options); > > argc = parse_options(argc, argv, prefix, options, builtin_backfill_usage, > - 0); > + PARSE_OPT_KEEP_UNKNOWN_OPT | > + PARSE_OPT_KEEP_ARGV0 | > + PARSE_OPT_KEEP_DASHDASH); > + > + repo_init_revisions(repo, &ctx.revs, prefix); > + argc = setup_revisions(argc, argv, &ctx.revs, NULL); We should probably die here in case we still have unknown arguments. Patrick