From: Derrick Stolee <derrickstolee@github.com>
Date: Thu, 24 Feb 2022 15:56:44 GMT
Subject: Re: [PATCH 10/23] fsmonitor-settings: remote repos on Windows are incompatible with FSMonitor
Message-ID: <ac59cfaa-1323-df83-de03-f7886699bc24@github.com>
In-Reply-To: <ae09fb10c3ad5ea129c88addd07ebe674a22793d.1644940774.git.gitgitgadget@gmail.com>

On 2/15/2022 10:59 AM, Jeff Hostetler via GitGitGadget wrote:
> From: Jeff Hostetler <jeffhost@microsoft.com>
...
> @@ -31,5 +129,9 @@ enum fsmonitor_reason fsm_os__incompatible(struct repository *r)
>  	if (reason)
>  		return reason;
>  
> +	reason = is_remote(r);
> +	if (reason)
> +		return reason;
> +
>  	return FSMONITOR_REASON_ZERO;

Just popping in to say that

	return is_virtual(r) ||
	       is_remote(r);

would work here, but we might remove is_virtual().

Thanks,
-Stolee