From: Patrick Steinhardt Date: Thu, 02 Apr 2026 07:46:11 GMT Subject: Re: [PATCH 04/10] promisor-remote: reject empty name or URL in advertised remote Message-ID: In-Reply-To: <20260402070613.85934-5-christian.couder@gmail.com> On Thu, Apr 02, 2026 at 09:06:07AM +0200, Christian Couder wrote: > In parse_one_advertised_remote(), we check for a NULL remote name and > remote URL, but not for empty ones. An empty URL seems possible as > url_percent_decode("") doesn't return NULL. > > In promisor_config_info_list(), we ignore remotes with empty URLs, so a > Git server should not advertise remotes with empty URLs. It's possible > that a buggy or malicious server would do it though. > > So let's tighten the check in parse_one_advertised_remote() to also > reject empty strings at parse time. Makes sense. Patrick