From: Patrick Steinhardt Date: Wed, 01 Apr 2026 13:46:49 GMT Subject: Re: [PATCH 03/12] transport-helper: drop const to fix strchr() warnings Message-ID: In-Reply-To: <20260331234148.GC2328529@coredump.intra.peff.net> On Tue, Mar 31, 2026 at 07:41:48PM -0400, Jeff King wrote: > We implicitly drop the const from our "key" variable when we do: > > char *p = strchr(key, ' '); > > which causes compilation with some C23 versions of libc (notably recent > glibc) to complain. > > We need "p" to remain writable, since we assign NULL over the space we You probably mean NUL, not NULL. Patrick