From: Phillip Wood <phillip.wood123@gmail.com>
Date: Mon, 30 Jun 2025 08:59:48 GMT
Subject: Re: [PATCH v2] daemon: correctly handle soft accept() errors in service_loop
Message-ID: <abf3aabb-8e46-4324-9e35-634cdaf110fb@gmail.com>
In-Reply-To: <xmqqy0tc68s4.fsf@gitster.g>

On 28/06/2025 00:53, Junio C Hamano wrote:
> Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
> 
>> That seems unnecessarily restrictive just to minimize churn and leaves the
>> deflaration of incoming strangely sitting in between two assignments, which
>> while it doesn't trigger -Wdeclaration-after-statement seems to go against
>> its spirit.
> 
> Hmph, I am not Phillip, but my take on it is that incoming and retry
> are fairly closely related variables in this loop, and better
> grouped together?

That was my thinking too

Thanks

Phillip