From: Michael Spang <spang@google.com>
Date: Wed, 27 Jan 2010 22:51:02 GMT
Subject: Re: [PATCH] Fix git rev-list --reverse --max-count=N
Message-ID: <abef960f1001271451n5ed454aaye1591ea35729b53f@mail.gmail.com>
In-Reply-To: <7vsk9rnpxo.fsf@alter.siamese.dyndns.org>

On Wed, Jan 27, 2010 at 5:28 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Johannes Sixt <j6t@kdbg.org> writes:
>
> The interaction between --max-count and --reverse was designed a long time
> ago to support "I want to review the recent N commits in order to make
> sure that they are natural and logical progression".  So an unconditional
> change of semantics to break that expectation this late in the game will
> never be acceptable, and giving title to such a patch with a word "Fix"
> won't fly well (it simply _breaks_ behaviour users have long learned to
> expect).

You have my apology for calling it a fix. I just don't have the same
visibility into what undocumented behavior users depend on that you
do, and so I thought it actually was one.

The patch can die here. I understand the current behavior now, and I
don't have a strong need for the behavior I expected (piping to head
works fine).

Michael