From: Justin Tobler <jltobler@gmail.com>
Date: Fri, 13 Mar 2026 23:05:46 GMT
Subject: Re: [PATCH 1/1] Add preparing state to reference-transaction hook
Message-ID: <abSWrcvm-smx92MY@denethor>
In-Reply-To: <20260313193537.62827-2-eric.peijian@gmail.com>

On 26/03/13 03:35PM, eric.peijian@gmail.com wrote:
> diff --git a/refs.c b/refs.c
> index 6fb8f9d10c..f1439476d3 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -2655,6 +2655,13 @@ int ref_transaction_prepare(struct ref_transaction *transaction,
>  	if (ref_update_reject_duplicates(&transaction->refnames, err))
>  		return REF_TRANSACTION_ERROR_GENERIC;
>  
> +	/* Preparing checks before locking references */
> +	ret = run_transaction_hook(transaction, "preparing");
> +	if (ret) {
> +		ref_transaction_abort(transaction, err);
> +		die(_("ref updates aborted by %s hook"), "preparing");

Should "preparing" be marked for translation here?

> +	}
> +
>  	ret = refs->be->transaction_prepare(refs, transaction, err);
>  	if (ret)
>  		return ret;
> @@ -2662,7 +2669,7 @@ int ref_transaction_prepare(struct ref_transaction *transaction,
>  	ret = run_transaction_hook(transaction, "prepared");
>  	if (ret) {
>  		ref_transaction_abort(transaction, err);
> -		die(_("ref updates aborted by hook"));
> +		die(_("ref updates aborted by %s hook"), "prepared");

Same question here for "prepared"?

Thanks,
-Justin