From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 13 Mar 2026 06:23:17 GMT
Subject: Re: [PATCH v3 0/2] run-command: stop using the_repository
Message-ID: <abOtVYg1S_7aNNru@pks.im>
In-Reply-To: <xmqqa4wdhxqn.fsf@gitster.g>

On Thu, Mar 12, 2026 at 08:29:52AM -0700, Junio C Hamano wrote:
> Burak Kaan Karaçay <bkkaracay@gmail.com> writes:
> 
> > This patch series aims to remove the_repository dependency in
> > 'run-command.c'.
> >
> > The first patch removes the dependency in start_command() by replacing
> > the boolean 'close_object_store' flag with a pointer to the target
> > object store.
> >
> > The second patch handles the prepare_auto_maintenance() and
> > run_auto_maintenance() functions by passing a 'struct repository *'
> > parameter. With no global repository dependencies left, it drops the
> > USE_THE_REPOSITORY_VARIABLE macro from the file.
> >
> > Changes in v3:
> > - Added the second patch at the suggestion of Patrick to fully clean up
> >   the file.
> 
> [1/2] is now exactly as expected from the previous discussion.  The
> only miniscule thing I found in [2/2] was a new blank line
> introduced here, which seemed unnecessary and not in line with the
> existing style in that function.
> 
> Otherwise, looking very good.  Will queue.  Thanks.

Agreed, this looks good to me. Thanks!

Patrick