From: Patrick Steinhardt Date: Thu, 12 Mar 2026 06:22:02 GMT Subject: Re: [PATCH 7/8] meson: compile compatibility sources separately Message-ID: In-Reply-To: On Wed, Mar 11, 2026 at 02:56:24PM +0000, Phillip Wood wrote: > On 11/03/2026 14:32, Phillip Wood wrote: > > On 10/03/2026 17:52, Patrick Steinhardt wrote: > > > In the next commit we're about to introduce a precompiled header for > > > "git-compat-util.h". The consequence of this change is that we'll > > > implicitly include that header for every compilation unit that uses the > > > precompiled headers. > > > > Is that a meson thing? I know it defines precompiled headers on a per- > > target basis but does it somehow force each source file to include the > > precompiled header? Looking at the gcc documentation it seems like the > > precompiled header is only included where the original header is > > included. > > Answering my own question the precompiled header is included via "-include" > on the commandline. This is necessary in the general case because a > precompiled header cannot be used once the first C token is seen. > > As an aside in git we could probably get away without using "-include" > because if we include "git-compat-util.h" it is always the first thing we > do, or we inculde another file like "builtin.h" which immediately includes > "git-compat-util.h" and so it is included before the first C token is seen. > However meson cannot rely on that. > > I notice the reftable sources don't seem to include "git-compat-util.h", do > they need special handling here as well? I don't see a strong reason to do so. The reason why we need to be careful with "compat/" is that we redefine a bunch of standard symbols there, and that requires us to play a couple of tricks with preprocessor macros (see e.g. "compat/fopen.c"). We don't do anything like that in the reftable library, and we already include "compat/posix.h". So in practice, it shouldn't have much of a consueqence if we start to include "git-compat-util.h" implicitly over there. But if it ever does we can treat it the same as the compat library. Patrick