From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 12 Mar 2026 06:07:26 GMT
Subject: Re: [PATCH v2] t3200: replace hardcoded null OID with $ZERO_OID
Message-ID: <abJYHmKiXqiXjHhN@pks.im>
In-Reply-To: <20260311174120.76871-1-r.siddharth.shrimali@gmail.com>

On Wed, Mar 11, 2026 at 11:11:20PM +0530, Siddharth Shrimali wrote:
> To support the SHA-256 transition, replace the hardcoded 40-zero string
> in 'git branch --merged' with '$ZERO_OID'. The current 40-character
> string causes the test to fail prematurely in SHA-256 environments
> because Git identifies a "malformed object name" (due to the 40 vs 64
> character mismatch) before it even validates the object type.
> 
> By using '$ZERO_OID', we ensure the hash length is always correct for
> the active algorithm. Additionally, use 'test_grep' to verify the
> "must point to a commit" error message, ensuring the test validates
> the object type logic rather than just string syntax.
> 
> Suggested-by: Patrick Steinhardt <ps@pks.im>

"Suggested-by" is a bit strong, as it indicates that I have suggested
to work on this in the first place. "Helped-by" would have been a bit of
a better fit.

No reason to reroll though, this patch looks good to me. Thanks!

Patrick