From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Wed, 11 Mar 2026 21:17:26 GMT
Subject: Re: [PATCH v2] t3200: replace hardcoded null OID with $ZERO_OID
Message-ID: <abHb5k4otqTSgPb8@fruit.crustytoothpaste.net>
In-Reply-To: <20260311174120.76871-1-r.siddharth.shrimali@gmail.com>

On 2026-03-11 at 17:41:20, Siddharth Shrimali wrote:
> diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh
> index c58e505c43..e7829c2c4b 100755
> --- a/t/t3200-branch.sh
> +++ b/t/t3200-branch.sh
> @@ -1494,7 +1494,8 @@ test_expect_success 'refuse --edit-description on unborn branch for now' '
>  '
>  
>  test_expect_success '--merged catches invalid object names' '
> -	test_must_fail git branch --merged 0000000000000000000000000000000000000000
> +	test_must_fail git branch --merged $ZERO_OID 2>err &&
> +	test_grep "must point to a commit" err
>  '

Yeah, this seems reasonable.  It's failing, but for the wrong reasons,
so checking the error message in addition to switching to `$ZERO_OID`
seems like the right thing to do.
-- 
brian m. carlson (they/them)
Toronto, Ontario, CA