From: Derrick Stolee Date: Fri, 15 Jun 2018 14:15:50 GMT Subject: Re: [PATCH 3/3] ewah: drop ewah_serialize_native function Message-ID: In-Reply-To: On 6/15/2018 9:56 AM, Ramsay Jones wrote: > > On 15/06/18 04:32, Jeff King wrote: >> We don't call this function, and never have. The on-disk >> bitmap format uses network-byte-order integers, meaning that >> we cannot use the native-byte-order format written here. >> >> Let's drop it in the name of simplicity. > Hmm, if you are in the mood to drop ewah dead code, how about: > > ewah/bitmap.o - bitmap_clear > ewah/bitmap.o - bitmap_each_bit > ewah/ewah_bitmap.o - ewah_and > ewah/ewah_bitmap.o - ewah_and_not > ewah/ewah_bitmap.o - ewah_not > ewah/ewah_bitmap.o - ewah_or > > ... in addition to these *(de)serialize* functions. ;-) > Normally, I would say we should keep this folder as close to the "original" [1] as possible, so we could more easily take improvements to that library. However, it appears that code is not being updated. Perhaps this is in favor of other EWAH libraries [2] or other compressed bitmap formats [3]. For that reason, I agree we should clean this up. We shouldn't block Peff's patch for that reason. I'll send a patch that deletes these methods. Thanks, -Stolee: [1] https://github.com/vmg/libewok [2] https://github.com/lemire/EWAHBoolArray [3] https://github.com/RoaringBitmap/CRoaring