From: Arnav Bhate Date: Tue, 11 Mar 2025 18:23:53 GMT Subject: Re: Defining timestamp_t as intmax_t instead of uintmax_t Message-ID: In-Reply-To: Junio C Hamano writes: > Arnav Bhate writes: > >> timestamp_t is a data type defined in git-compat-util.h as uintmax_t since >> 28f4aee3fb (use uintmax_t for timestamps, 2017-04-26). It was introduced with >> dddbad728c (timestamp_t: a new data type for timestamps, 2017-04-26) to replace >> use of both time_t and unsigned long for time-related uses. > > I do not think the object format and the existing object parsers are > prepared to handle timestamp before the epoch. Looks like I bit off more than I could chew. Maybe this could be a medium-sized project in itself. > You may want to go back to the list archive for discussions around > the choice of the type back then, which should have enough > information to go by. > > https://lore.kernel.org/git/20170228200145.ymbqmxwrbbrwagks@sigill.intra.peff.net/ > > might be a good starting point. > > https://lore.kernel.org/git/?q=f:peff@+d:20170201..20170430+timestamp_t > > gives 6 entry points to a single large thread that may be worth > following before tackling this topic further. > > Thanks. I'll go through it. -- Regards, Arnav Bhate (He/Him)