From: Derrick Stolee <stolee@gmail.com>
Date: Tue, 24 Aug 2021 16:55:07 GMT
Subject: Re: [PATCH v4 00/10] serve.[ch]: general API cleanup + --advertise-refs cleanup
Message-ID: <ab23d3dc-bec3-9ab8-87d3-264b158aabba@gmail.com>
In-Reply-To: <cover-v4-00.10-00000000000-20210805T011823Z-avarab@gmail.com>

On 8/4/2021 9:25 PM, Ævar Arnfjörð Bjarmason wrote:
> This is a general API cleanup and simplifiction of of serve.[ch] and
> its interaction with "upload-pack --advertise-refs".

s/simplifiction/simplification/ (not that it matters much)

The changes included in this series seem innocent enough. The added
tests are nice. Organizing struct initializers is good to do before
adding options, which I see are coming later.

This version LGTM.

Thanks,
-Stolee