From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 05 Mar 2026 14:27:26 GMT
Subject: Re: [PATCH v3 0/2] oidmap: migrate cleanup to oidmap_clear_with_free()
Message-ID: <aamSznHdv4g97R6C@pks.im>
In-Reply-To: <20260305100526.102130-1-kuforiji98@gmail.com>

On Thu, Mar 05, 2026 at 11:05:24AM +0100, Seyi Kuforiji wrote:
> Hi,
> 
> This series replaces oidmap_clear(map, 1) with
> oidmap_clear_with_free() and introduces explicit free callbacks
> at the remaining call sites.
> 
> The old boolean-based API implicitly assumed plain free(),
> which obscures ownership semantics and does not work well
> when oidmap_entry is embedded inside larger structures.
> The callback-based API makes cleanup explicit and type-safe,
> and avoids relying on hidden assumptions about allocation.
> 
> This is used in subsequent commits to adequately cleanup all
> usage site.
> 
> Changes in v3:
>  - rename funtion to meet guidlines
>  - drop [PATCH 3/5]

Thanks, this version looks good to me!

Patrick