From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 04 Mar 2026 06:57:40 GMT
Subject: Re: [PATCH v2 2/5] builtin/rev-list: migrate missing_objects cleanup to oidmap_clear_with_free()
Message-ID: <aafX5CmP82WYFyIb@pks.im>
In-Reply-To: <20260302200018.75731-3-kuforiji98@gmail.com>

On Mon, Mar 02, 2026 at 09:00:14PM +0100, Seyi Kuforiji wrote:
> diff --git a/builtin/rev-list.c b/builtin/rev-list.c
> index ddea8aa251..ab5f69826c 100644
> --- a/builtin/rev-list.c
> +++ b/builtin/rev-list.c
> @@ -88,9 +88,19 @@ static int arg_print_omitted; /* print objects omitted by filter */
>  
>  struct missing_objects_map_entry {
>  	struct oidmap_entry entry;
> -	const char *path;
> +	char *path;
>  	unsigned type;
>  };
> +
> +static void free_missing_objects_entry(void *e)

Nit: this should be called `missing_objects_map_entry_free()` according
to our coding guidelines.

Patrick