From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 04 Mar 2026 05:16:25 GMT
Subject: Re: [PATCH 2/2] t7412: modernize path checks to use test helper functions
Message-ID: <aafAKc41y4CdZmUt@pks.im>
In-Reply-To: <20260303175750.361563-2-ysinghcin@gmail.com>

On Tue, Mar 03, 2026 at 11:27:50PM +0530, Yuvraj Singh Chauhan wrote:
> Replace 11 raw 'test -f', 'test -d', and '! test -e' calls with the

This explicit number of course made me verify that you didn't miscount,
and you indeed didn't :)

> corresponding test library helpers:
> 
>   - 'test -f' -> 'test_path_is_file'
>   - 'test -d' -> 'test_path_is_dir'
>   - '! test -e' -> 'test_path_is_missing'
> 
> These helpers emit a descriptive message on failure, 
> making failing tests easier to diagnose than the silent 
> pass/fail of the raw shell primitives.

Yup, the reasoning is sound.

By the way, you have trailing whitespace in the commit message. I guess
it'll get stripped when Junio applies the patch anyway, but maybe
something to watch out for in the future.

> diff --git a/t/t7412-submodule-absorbgitdirs.sh b/t/t7412-submodule-absorbgitdirs.sh
> index 41ee035e3c..cdc7f59e12 100755
> --- a/t/t7412-submodule-absorbgitdirs.sh
> +++ b/t/t7412-submodule-absorbgitdirs.sh

The changes all look obviously correct to me. Thanks!

Patrick