From: Justin Tobler <jltobler@gmail.com>
Date: Sun, 08 Mar 2026 18:44:09 GMT
Subject: Re: [PATCH v3 0/6] builtin/repo: include largest object information
Message-ID: <aa3DNVshSsAjFY1y@denethor>
In-Reply-To: <xmqq342cy49e.fsf@gitster.g>

On 26/03/06 02:36PM, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Justin Tobler <jltobler@gmail.com> writes:
> >
> >> Changes from V2:
> >> - When checking for largest objects, zero valued objects were not
> >>   recorded even if they were the "largest" object. In this version, if
> >>   an object ID has not been recorded yet, it is always added even if its
> >>   value is zero.
> >> - Added some helper functions for printing keyvalue info to cut down on
> >>   duplicate code and hopefully make it a bit easier on the eyes.
> >> - Moved the for-each loop that printed table OID annoations inside the
> >>   preceding if-block making it a bit easier to reason about.
> >
> > The changes I see in the diff relative to the previous iteration all
> > look sane to me.  Will replace.  Thanks.
> 
> It seems that no further review comments are coming and new
> iterations are not happening on this topic, so shall we declare
> victory and mark the topic for 'next' now?

From my perspective, I think this topic is good for 'next' now.

Thanks,
-Justin