From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 24 Feb 2026 09:35:07 GMT
Subject: Re: [PATCH v2 0/5] builtin/repo: include largest object information
Message-ID: <aZ1wy55xSaAOye49@pks.im>
In-Reply-To: <20260223174120.2356504-1-jltobler@gmail.com>

On Mon, Feb 23, 2026 at 11:41:15AM -0600, Justin Tobler wrote:
> Range-diff against v1:
> 1:  94a44e0e0f = 1:  94a44e0e0f builtin/repo: update stats for each object
> 2:  92dbf34f2c = 2:  92dbf34f2c builtin/repo: collect largest inflated objects
> 3:  1811d03afe ! 3:  1457d5d59c builtin/repo: add OID annotations to table output
>     @@ builtin/repo.c: static void stats_table_vaddf(struct stats_table *table,
>      +		entry->index = table->annotations.nr + 1;
>      +		strbuf_addf(&buf, "[%" PRIuMAX "] %s", (uintmax_t)entry->index,
>      +			    oid_to_hex(entry->oid));
>     -+		string_list_append(&table->annotations, buf.buf);
>     ++		string_list_append_nodup(&table->annotations, strbuf_detach(&buf, NULL));
>      +	}
>       	if (entry->value) {
>       		int value_width = utf8_strwidth(entry->value);
> 4:  471d352cc1 = 4:  f4e92e3f09 builtin/repo: find commit with most parents
> 5:  7f1b7f9657 = 5:  af404fcc6c builtin/repo: find tree with most entries

Thanks, this addresses my only comment I had on the first version.

Patrick