From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 06 Feb 2026 16:05:15 GMT
Subject: Re: [PATCH v2 1/2] checkout: pass program-readable token to unified "main"
Message-ID: <aYYROwDxrHU-H3n_@pks.im>
In-Reply-To: <20260129190616.645471-2-gitster@pobox.com>

On Thu, Jan 29, 2026 at 11:06:15AM -0800, Junio C Hamano wrote:
> diff --git a/builtin/checkout.c b/builtin/checkout.c
> index f9453473fe..4f189fde48 100644
> --- a/builtin/checkout.c
> +++ b/builtin/checkout.c
[snip]
> +	switch (which_command) {
> +	case CHECKOUT_CHECKOUT:
> +		usagestr = checkout_usage;
> +		break;
> +	case CHECKOUT_SWITCH:
> +		usagestr = switch_branch_usage;
> +		break;
> +	case CHECKOUT_RESTORE:
> +		usagestr = restore_usage;
> +		break;
> +	default:
> +		BUG("No such checkout variant %d", which_command);
> +	}

Tiniest nit, really not worth addressing on its own: BUG messages
typically start with a lower-case letter.

Other than that I like that we have less global constants with this
change.

Patrick