From: Taylor Blau <me@ttaylorr.com>
Date: Mon, 02 Feb 2026 02:14:20 GMT
Subject: Re: [PATCH v2 4/4] bisect: simplify string_list memory handling
Message-ID: <aYAIfKW8Vd0iBun9@nand.local>
In-Reply-To: <xmqqqzr76nuj.fsf@gitster.g>

On Fri, Jan 30, 2026 at 08:56:36AM -0800, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
> > It was written this way originally because one of the callsites
> > generated the item using xstrfmt(). But that spot switched to a plain
> > xstrdup() in the preceding commit. That means we can now just let the
> > string_list code handle allocation itself.
>
> Thanks for an extra attention to the detail of the way to refer the
> previous change ;-).
>
> I think [2/4] is a good direction myself, but I'd prefer to hear
> Taylor's opinion as well.

After thinking it over and re-reading the second round, I am still not
quite convinced that this is the right approach. I left some more
thoughts on possible alternatives in my response to [2/4].

Thanks,
Taylor