From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 21 Jan 2026 07:39:12 GMT
Subject: Re: [PATCH 07/14] odb: introduce `odb_for_each_object()`
Message-ID: <aXCCoI76k2zjioWb@pks.im>
In-Reply-To: <CAOLa=ZSgODbmRAHopGejyr1swhDzRa9rccM8TBc3CW=WkRe=pw@mail.gmail.com>

On Tue, Jan 20, 2026 at 09:20:05AM +0000, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/odb.h b/odb.h
> > index f97f249580..8f6d95aee5 100644
> > --- a/odb.h
> > +++ b/odb.h
> > @@ -475,6 +475,23 @@ typedef int (*odb_for_each_object_cb)(const struct object_id *oid,
> >  				      struct object_info *oi,
> >  				      void *cb_data);
> >
> > +/*
> > + * Iterate through all objects contained in the object database. Note that
> > + * objects may be iterated over multiple times in case they are either stored
> > + * in different backends or in case they are stored in multiple sources.
> > + *
> > + * Returning a non-zero error code will cause iteration to abort. The error
> > + * code will be propagated.
> > + *
> 
> Super-Nit: This is for the callback function. It would be nice to be
> explicit about that.

Makes sense indeed, will change.

Patrick