From: Todd Zullinger <tmz@pobox.com>
Date: Sat, 31 Jan 2026 20:55:16 GMT
Subject: Re: [PATCH] .github/CONTRIBUTING.md: fix broken link to SubmittingPatches
Message-ID: <aX5sNO4aMVE-qcrz@teonanacatl.net>
In-Reply-To: <xmqqms1t4l4z.fsf@gitster.g>

Junio C Hamano wrote:
> Abdalrhman Mohamed <eng.abdalrhman.abdalmonem@gmail.com> writes:
> 
>> -In addition, we highly recommend you to read [our submission guidelines](../Documentation/SubmittingPatches).
>> +In addition, we highly recommend you to read [our submission guidelines](https://github.com/git/git/blob/master/Documentation/SubmittingPatches).
> 
> The line is overly long already in the original; can we make it a
> bit more readable?
> 
> As to the contents, referring to our preformatted docs, like
> 
>     https://git.github.io/htmldocs/SubmittingPatches
> 
> would probably be more appropriate, no?

A few lines below, the document links to git-scm.com/docs:

    Or, you can follow the ["My First Contribution"](https://git-scm.com/docs/MyFirstContribution)
    tutorial for another example of the contribution process.

I didn't look at any discussion around b75a219904 (docs:
mention MyFirstContribution in more places, 2020-06-08)
where that was added.  It would make sense to be consistent
about where the links point, e.g.:

    https://git-scm.com/docs/SubmittingPatches

As CONTRIBUTING.md is in the .github directory, it's
probably fine to link there for both.  On the other hand,
having more references to the upstream site might be good
for consistency across the various places the Git code is
hosted.  Maybe that increases the standing of git-scm.com in
search rankings too, I don't know.

Whatever the reasoning, it should probably apply to both
links.

-- 
Todd