From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 14 Jan 2026 10:56:15 GMT
Subject: Re: [PATCH v2 2/3] last-modified: remove double error message
Message-ID: <aWd2T2mJSvE3XCZN@pks.im>
In-Reply-To: <20260114-toon-last-modified-tree-v2-2-ba3b1860898f@iotcl.com>

On Wed, Jan 14, 2026 at 11:24:46AM +0100, Toon Claes wrote:
> diff --git a/builtin/last-modified.c b/builtin/last-modified.c
> index 06e3f79aec..0df85be318 100644
> --- a/builtin/last-modified.c
> +++ b/builtin/last-modified.c
> @@ -495,7 +495,7 @@ static int last_modified_init(struct last_modified *lm, struct repository *r,
>  	lm->rev.bloom_filter_settings = get_bloom_filter_settings(lm->rev.repo);
>  
>  	if (populate_paths_from_revs(lm) < 0)
> -		return error(_("unable to setup last-modified"));
> +		return -1;

Makes sense. There's only one error condition in the function, and that
error condition already prints an error message.

Patrick