From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 12 Jan 2026 08:40:46 GMT
Subject: Re: [PATCH v3 2/2] repo: add new flag --keys to git-repo-info
Message-ID: <aWSzjnqtvpwYnJlX@pks.im>
In-Reply-To: <20260109211554.90828-4-lucasseikioshiro@gmail.com>

On Fri, Jan 09, 2026 at 05:31:53PM -0300, Lucas Seiki Oshiro wrote:
> diff --git a/Documentation/git-repo.adoc b/Documentation/git-repo.adoc
> index fa0e6600af..4471816cc8 100644
> --- a/Documentation/git-repo.adoc
> +++ b/Documentation/git-repo.adoc
> @@ -47,6 +48,16 @@ supported:
>  +
>  `-z` is an alias for `--format=nul`.
>  
> +`info --keys [--format=(default|nul) | -z]`::
> +	List all the available keys, one per line. The output format can be chosen
> +	through the flag `--format`. The following formats are supported:
> ++
> +`default`:::
> +	output the keys one per line.
> +
> +`nul`:::
> +	similar to `default`, but using a NUL character after each value.
> +
>  `structure [--format=(default|table|keyvalue|nul) | -z]`::
>  	Retrieve statistics about the current repository structure. The
>  	following kinds of information are reported:

I think it's slightly unfortunate that the default format cannot be
explicitly chosen. "keyvalue" of course doesn't make sense, but maybe we
should have a format "newline" that can be specified?

Other than that the patches look good to me, thanks!

Patrick