From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 12 Jan 2026 08:25:21 GMT
Subject: Re: [RFC PATCH] t5500-fetch-pack.sh: fix suppression of Git exit code in tests
Message-ID: <aWSv8dlt32xg14e1@pks.im>
In-Reply-To: <xmqq8qe3pxvm.fsf@gitster.g>

On Sun, Jan 11, 2026 at 02:50:37PM -0800, Junio C Hamano wrote:
> Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> writes:
> >  	GIT_PROTOCOL=version=2 git upload-pack . <<-EOF >/dev/null
> >  	0012command=fetch
> > -	$(echo "object-format=$(test_oid algo)" | packetize)
> > +	$(echo "object-format=$(<oid_algo)" | packetize)
> 
> The construct $(<file) is bashism, that does not work if your shell
> is not bash, isn't it?  If you used a variable, e.g.,
> 
> 	$(echo "object-format=$oid_algo" | packetize)
> 
> that would make the result more portable.

There's no need for the echo at all as this can also be written as:

    packetize "object-format=$oid_algo"

Patrick