From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 12 Jan 2026 08:18:06 GMT
Subject: Re: [PATCH 00/17] Fixes and improvements for ref consistency checks
Message-ID: <aWSuPkzH4RsG472A@pks.im>
In-Reply-To: <aWJWCiTFQAZqDb9y@ArchLinux>

On Sat, Jan 10, 2026 at 09:37:14PM +0800, shejialuo wrote:
> On Fri, Jan 09, 2026 at 01:39:29PM +0100, Patrick Steinhardt wrote:
> > Hi,
> > 
> > this patch series contains a bunch of fixes and improvements for ref
> > consistency checks. It is structured as follows:
> > 
> >   - Patches 1 to 4 contain a couple of cleanups for the consistency
> >     checks done by the "files" backend.
> > 
> >   - Patches 5 to 7 introduce checks for root refs for the "files"
> >     backend.
> > 
> >   - Patches 9 to 14 introduce infrastructure for shared checks with the
> >     "files" and "reftable" backend.
> > 
> >   - Patches 15 to 17 move some ref consistency checks that were still
> >     driven by git-fsck(1) into `git refs verify`.
> > 
> > Thanks!
> > 
> > Patrick
> 
> I left some comments. In conclusion, I very appreciate the direction to
> share the common logic for both "files" backend and "reftable" backend.
> And also, we could check the correctness of `HEAD` to make the ref
> subsystem self-contained.

Thanks for your review!

Patrick