From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 12 Jan 2026 08:17:48 GMT
Subject: Re: [PATCH 09/17] refs/files: extract generic symref target checks
Message-ID: <aWSuLIzHPDSxMg9y@pks.im>
In-Reply-To: <aWJNHgFnimXRHkb6@ArchLinux>

On Sat, Jan 10, 2026 at 08:59:10PM +0800, shejialuo wrote:
> On Fri, Jan 09, 2026 at 01:39:38PM +0100, Patrick Steinhardt wrote:
> > diff --git a/refs/files-backend.c b/refs/files-backend.c
> > index 0ff047d0df..72c1db849e 100644
> > --- a/refs/files-backend.c
> > +++ b/refs/files-backend.c
> > @@ -3718,53 +3718,39 @@ typedef int (*files_fsck_refs_fn)(struct ref_store *ref_store,
> >  				  const char *path,
> >  				  int mode);
> >  
> > -static int files_fsck_symref_target(struct fsck_options *o,
> > +static int files_fsck_symref_target(struct ref_store *ref_store,
> > +				    struct fsck_options *o,
> >  				    struct fsck_ref_report *report,
> > +				    const char *refname,
> >  				    struct strbuf *referent,
> >  				    unsigned int symbolic_link)
> 
> 
> Nit: as we touch this function, maybe we could change `unsigned int
> symbolic_link` to be `bool symbolic_link`.

I'd prefer to not have this while-at-it change. The benefit isn't clear
enough to actually change it, and it would distract from the actual
changes a bit.

Patrick