From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 05 Jan 2026 14:18:33 GMT
Subject: Re: [PATCH v2 2/2] repo: add new flag --keys to git-repo-info
Message-ID: <aVvIOVVKZVjGCDrL@pks.im>
In-Reply-To: <20251209194616.61620-3-lucasseikioshiro@gmail.com>

On Tue, Dec 09, 2025 at 04:36:03PM -0300, Lucas Seiki Oshiro wrote:
> diff --git a/Documentation/git-repo.adoc b/Documentation/git-repo.adoc
> index c4a78277df..fd0683631c 100644
> --- a/Documentation/git-repo.adoc
> +++ b/Documentation/git-repo.adoc
> @@ -9,6 +9,7 @@ SYNOPSIS
>  --------
>  [synopsis]
>  git repo info [--format=(keyvalue|nul) | -z] [--all | <key>...]
> +git repo info --keys [--format=(default|nul) | -z]
>  git repo structure [--format=(table|keyvalue|nul) | -z]
>  
>  DESCRIPTION

The synopsis should have been updated in the preceding commit to mention
"default" for `git repo info`.

> @@ -131,4 +122,24 @@ test_expect_success 'git repo info --all <key> aborts' '
>  	test_cmp expect actual
>  '
>  
> +test_expect_success 'git repo info --keys --format=nul uses nul-terminated output' '
> +	git repo info --keys --format=default >default &&
> +	lf_to_nul <default > expect &&

Style nit: there shouldn't be a space between "> expect".

Patrick