From: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date: Thu, 18 Dec 2025 10:59:23 GMT
Subject: Re: [PATCH] odb: do not use "blank" substitute for NULL
Message-ID: <aUPbgCSTgWJAe0wu@Carlos-MacBook-Air.local>
In-Reply-To: <0e860421-8f8c-4bf9-8ad8-82fe269a7a9d@app.fastmail.com>

On Thu, Dec 18, 2025 at 09:02:59AM -0800, Kristoffer Haugsbakk wrote:
> On Thu, Dec 18, 2025, at 05:51, Aaron Plattner wrote:
> >>[snip]
> >> By explicitly handling NULL input, we no longer have to worry about
> >> it.
> >
> > This reasoning makes sense to me.
> >
> > Would it make sense to add a
> >
> > Fixes: 385e18810f10 ("packfile: introduce function to read object info
> > from a store")
> >
> > line?
> 
> This project typically does not use that trailer/tag.

While factually correct, I think the "why" is more interesting in this case.
anf the answer IMHO is: not, because it is not needed.

% git describe 385e18810f10 
v2.52.0-25-g385e18810f

shows that this bug is only present after 2.52.0 was released so unless you
are using unreleased version of git (ex: some development version, including
ones that are based on "next"), there is no need to "backport" this fix, as
the next version you will use will include it.

Carlo


 Only trailers that
> attribute people are recommended. There are exceptions, like some
> recent usages of
> 
>     Best-viewed-with: <option to git-log(1)/git-show(1)>
> 
> If a commit fixes some other commit it might be referenced somewhere in
> the message text.
> 
> Commits are referenced with:[1]
> 
>      git show -s --pretty=reference <commit>
> 
> The maintainer uses `--abbrev=8` (simplified):[2]
> 
>     git show --date=short -s --abbrev=8 --pretty='format:%h (%s, %ad)' "$1"
> 
> † 1: Documentation/SubmittingPatches
> [2]: https://lore.kernel.org/git/xmqq34j5h7v9.fsf@gitster.g/
> 
> >[snip]