From: Patrick Steinhardt <ps@pks.im>
Date: Sun, 23 Nov 2025 18:59:07 GMT
Subject: Re: [PATCH v2 13/19] streaming: get rid of `the_repository`
Message-ID: <aSNZeyoVWDVTU4X_@pks.im>
In-Reply-To: <xmqqh5un41fv.fsf@gitster.g>

On Fri, Nov 21, 2025 at 11:42:44AM -0800, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > diff --git a/streaming.h b/streaming.h
> > index f5ff5d7ac9..1a3de6812e 100644
> > --- a/streaming.h
> > +++ b/streaming.h
> > @@ -7,6 +7,7 @@
> >  #include "object.h"
> >  
> >  /* opaque */
> > +struct object_database;
> >  struct odb_read_stream;
> >  struct stream_filter;
> 
> Extremely minor, but "opaque" used to refer to the fact that "struct
> git_istream" is opaque to the users of this API.  In a later step
> you'll remove the opaque comment (perhaps your change in that step
> will stop it being opaque?), but until then, you'd want to keep the
> comment next to "struct odb_read_stream", as it is my understanding
> that object_database is not opaque here.

Good point, will fix.

Patrick