From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 21 Nov 2025 06:32:53 GMT
Subject: Re: [PATCH 06/18] streaming: create structure for in-core object streams
Message-ID: <aSAHlQtQuupprYw9@pks.im>
In-Reply-To: <CAOLa=ZRwk2DPCG-kWs-g7qtjBbXc9QuZgumxA3y54JsJjGpM=g@mail.gmail.com>

On Wed, Nov 19, 2025 at 10:14:28AM +0000, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> > @@ -426,22 +429,24 @@ static int open_istream_incore(struct odb_read_stream **out,
> >  			       const struct object_id *oid)
> >  {
> >  	struct object_info oi = OBJECT_INFO_INIT;
> > -	struct odb_read_stream stream = {
> > -		.close = close_istream_incore,
> > -		.read = read_istream_incore,
> > -	};
> > +	struct odb_incore_read_stream stream = {
> > +		.base.close = close_istream_incore,
> > +		.base.read = read_istream_incore,
> > +	}, *st;
> 
> Nit: Almost missed this `*st`. I wonder if its more readable as a
> separate line:
> 
>   struct odb_incore_read_stream *st;
> 
> All good otherwise.

Fair, will adapt.

Patrick