From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 14 Nov 2025 07:00:48 GMT
Subject: Re: [PATCH 3/9] Makefile: turn on NO_MMAP when building with ASan
Message-ID: <aRbToFLhzewwBaSv@pks.im>
In-Reply-To: <xmqqfrahq4j8.fsf@gitster.g>

On Thu, Nov 13, 2025 at 08:30:03AM -0800, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > On Wed, Nov 12, 2025 at 03:02:15AM -0500, Jeff King wrote:
> >> diff --git a/Makefile b/Makefile
> >> index 7e0f77e298..0f44268405 100644
> >> --- a/Makefile
> >> +++ b/Makefile
> >> @@ -1587,6 +1587,7 @@ SANITIZE_LEAK = YesCompiledWithIt
> >>  endif
> >>  ifneq ($(filter address,$(SANITIZERS)),)
> >>  NO_REGEX = NeededForASAN
> >> +NO_MMAP = NeededForASAN
> >>  SANITIZE_ADDRESS = YesCompiledWithIt
> >>  endif
> >>  endif
> >
> > Let's also apply this to Meson. Thanks!
> >
> > Patrick
> 
> Do you two want me to squash this into the Makefile patch?

I feel like there's going to be a revised version of this series anyway,
so that's probably not necessary. Thanks!

Patrick