From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 06 Nov 2025 07:22:02 GMT
Subject: Re: [PATCH] perl: also mark git-contacts executable
Message-ID: <aQxMmnzPR6swvG-d@pks.im>
In-Reply-To: <7fbb341e8f05fcde3a1543e3bb4e5a3ec1101692.1762280097.git.ben.knoble+github@gmail.com>

On Tue, Nov 04, 2025 at 01:14:57PM -0500, D. Ben Knoble wrote:
> When install git-contacts with Meson via -Dcontrib=contacts, the default

s/install/installing/

> Perl generation fails to mark it executable. As a result, "git contacts"
> reports "'contacts' is not a git command."
> 
> Unlike generate-script.sh, we aren't testing the basename here; so, glob
> the script name in the case arm to match wherever the input comes from.

Yeah, that feels sensibel to me.

> diff --git a/generate-perl.sh b/generate-perl.sh
> index 65f122ebfc..796d835932 100755
> --- a/generate-perl.sh
> +++ b/generate-perl.sh
> @@ -30,7 +30,7 @@
>      "$INPUT" >"$OUTPUT"
>  
>  case "$INPUT" in
> -*.perl)
> +*.perl|*git-contacts)
>  	chmod a+x "$OUTPUT";;
>  *)
>  	;;

And the change looks as expected. An alternative could of course be to
rename the file in-tree to "git-contacts.perl". In that case we wouldn't
require this special case at all. But I guess that this here is good
enough, and there might be other consequences if we renamed the script.

Thanks!

Patrick