From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 30 Oct 2025 08:58:28 GMT
Subject: Re: [PATCH 3/8] http: refactor subsystem to use `packfile_list`s
Message-ID: <aQMotPUNIPUfa6U-@pks.im>
In-Reply-To: <87h5vhrdjq.fsf@iotcl.com>

On Wed, Oct 29, 2025 at 03:24:41PM +0100, Toon Claes wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> diff --git a/packfile.c b/packfile.c
> > index 4d2d3b674f3..6aa2ca8ac9e 100644
> > --- a/packfile.c
> > +++ b/packfile.c
> > @@ -121,6 +121,15 @@ void packfile_list_append(struct packfile_list *list, struct packed_git *pack)
> >  	}
> >  }
> >  
> > +struct packed_git *packfile_list_find_oid(struct packfile_list_entry *packs,
> > +					  const struct object_id *oid)
> > +{
> 
> Why does it take a `struct packfile_list_entry` and not a `struct
> packfile_list` ?

This is because `packfile_store_get_packs()` returns the first entry and
not head itself. It makes the interface a bit easier to use going
forward.

Patrick