From: Taylor Blau <me@ttaylorr.com>
Date: Thu, 23 Oct 2025 19:29:08 GMT
Subject: Re: [PATCH v2 3/9] builtin/maintenance: introduce "geometric-repack" task
Message-ID: <aPqCBDLwVBKKaJU6@nand.local>
In-Reply-To: <20251021-pks-maintenance-geometric-strategy-v2-3-f0d727832b80@pks.im>

On Tue, Oct 21, 2025 at 04:13:25PM +0200, Patrick Steinhardt wrote:
> +test_expect_success 'geometric repacking task' '
> +	test_when_finished "rm -rf repo" &&
> +	git init repo &&
> +	(
> +		cd repo &&
> +		git config set maintenance.auto false &&
> +		test_commit initial &&
> +
> +		# The initial repack causes an all-into-one repack.
> +		GIT_TRACE2_EVENT="$(pwd)/initial-repack.txt" \
> +			git maintenance run --task=geometric-repack 2>/dev/null &&
> +		test_subcommand git repack -d -l --cruft --cruft-expiration=2.weeks.ago --quiet --write-midx <initial-repack.txt &&

Not a show-stopper of course, but I thought from the cover letter that
these lines would have gotten wrapped. Whether or not we have lines
longer than 80 characters is not a hill that I'd like to die on, of
course ;-). But I brought it up because I am wondering if there were
some changes that you meant to include as a part of this round that got
dropped in the shuffle.

Thanks,
Taylor