From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 23 Oct 2025 05:49:50 GMT
Subject: Re: [PATCH 4/9] xdiff: use unambiguous types in xdl_hash_record()
Message-ID: <aPnB_jEjn-nnRg82@pks.im>
In-Reply-To: <CAH=ZcbBeDNqW6PqhhzU75wttND86RfMRuNS2ga6KP1fN7AhFnw@mail.gmail.com>

On Wed, Oct 22, 2025 at 03:20:32PM -0600, Ezekiel Newren wrote:
> On Tue, Oct 21, 2025 at 2:33 AM Patrick Steinhardt <ps@pks.im> wrote:
> >
> > On Wed, Oct 15, 2025 at 09:18:16PM +0000, Ezekiel Newren via GitGitGadget wrote:
> > > From: Ezekiel Newren <ezekielnewren@gmail.com>
> >
> > This should have a commit message explaining what exactly you're doing
> > here.
> 
> I thought I did have a commit message justifying my changes. Maybe it
> got deleted through a rebase. How about a message like:
> 
> Convert the function signature and body to use unambiguous types. char
> is changed to uint8_t because this function processes bytes in memory.
> unsigned long to uint64_t so that the hash output is consistent across
> platforms. `flags` was changed from long to uint64_t to ensure the
> high order bits are not dropped on platforms that treat long as 32
> bits.

Works for me, I guess. Thanks!

Patrick