From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 21 Oct 2025 08:06:00 GMT
Subject: Re: [PATCH v3 3/5] strbuf: bring back is_rfc3986_unreserved
Message-ID: <aPc-6OBaFzO_jkXd@pks.im>
In-Reply-To: <20251006112518.3764240-4-adrian.ratiu@collabora.com>

On Mon, Oct 06, 2025 at 02:25:16PM +0300, Adrian Ratiu wrote:
> diff --git a/strbuf.h b/strbuf.h
> index a580ac6084..5139269039 100644
> --- a/strbuf.h
> +++ b/strbuf.h
> @@ -640,6 +640,8 @@ static inline void strbuf_complete_line(struct strbuf *sb)
>  
>  typedef int (*char_predicate)(char ch);
>  
> +int is_rfc3986_unreserved(char ch);

I think it would help if we had a short comment here explaining what it
does. I doubt that most people immediately go "Ah, RFC3986!". So maybe
explaining in a sentence or two what this is roughly doing would help
them.

Patrick