From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 10 Oct 2025 12:28:38 GMT
Subject: Re: [PATCH 41/49] builtin/repack.c: use `write_pack_opts` within `write_cruft_pack()`
Message-ID: <aOj79rYGyYWYUGGY@pks.im>
In-Reply-To: <7826afc17376f0d4a7f3169d9aafce21b3273ff5.1759097191.git.me@ttaylorr.com>

On Sun, Sep 28, 2025 at 06:09:57PM -0400, Taylor Blau wrote:
> diff --git a/builtin/repack.c b/builtin/repack.c
> index 6df7c88085..501359c580 100644
> --- a/builtin/repack.c
> +++ b/builtin/repack.c
> @@ -221,9 +221,7 @@ static void combine_small_cruft_packs(FILE *in, size_t combine_cruft_below_size,
>  	strbuf_release(&buf);
>  }
>  
> -static int write_cruft_pack(const struct pack_objects_args *args,
> -			    const char *destination,
> -			    const char *pack_prefix,
> +static int write_cruft_pack(struct write_pack_opts *opts,
>  			    const char *cruft_expiration,
>  			    unsigned long combine_cruft_below_size,
>  			    struct string_list *names,

Same question here regarding the constness. Subsequent patches also
surface this question.

Patrick