From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 10 Oct 2025 12:28:22 GMT
Subject: Re: [PATCH 40/49] builtin/repack.c: introduce `struct write_pack_opts`
Message-ID: <aOj75uPA6cFW9WhN@pks.im>
In-Reply-To: <109109618687efeb932bee7dd5882557ab0576f4.1759097191.git.me@ttaylorr.com>

On Sun, Sep 28, 2025 at 06:09:51PM -0400, Taylor Blau wrote:
> diff --git a/builtin/repack.c b/builtin/repack.c
> index 5fed79e826..6df7c88085 100644
> --- a/builtin/repack.c
> +++ b/builtin/repack.c
> @@ -138,9 +138,7 @@ static int finish_pack_objects_cmd(const struct git_hash_algo *algop,
>  	return finish_command(cmd);
>  }
>  
> -static int write_filtered_pack(const struct pack_objects_args *args,
> -			       const char *destination,
> -			       const char *pack_prefix,
> +static int write_filtered_pack(struct write_pack_opts *opts,
>  			       struct existing_packs *existing,
>  			       struct string_list *names)

Is there any reason why the new argument isn't marked as `const`?

Patrick