From: shejialuo <shejialuo@gmail.com>
Date: Sun, 05 Oct 2025 09:29:42 GMT
Subject: Re: [PATCH v2 3/4] string-list: change "string_list_find_insert_index" return type to "size_t"
Message-ID: <aOI6hrpSvp_RS5VY@ArchLinux>
In-Reply-To: <CAOLa=ZSGb_vvcneJ-b7ahL8J46a-FFKzupXaO0eKcyNehwTF+w@mail.gmail.com>

On Tue, Sep 23, 2025 at 05:44:42AM -0400, Karthik Nayak wrote:
> >  /** Determine if the string_list has a given string or not. */
> >  bool string_list_has_string(const struct string_list *list, const char *string);
> > -int string_list_find_insert_index(const struct string_list *list, const char *string,
> > -				  bool *exact_match);
> > +size_t string_list_find_insert_index(const struct string_list *list, const char *string,
> > +				     bool *exact_match);
> >
> 
> Super nit: can we also add documentation to this function while we're here.
> 

Sure, I would update this in the next version.

Thanks,
Jialuo