From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 29 Sep 2025 23:22:05 GMT
Subject: Re: [PATCH 27/49] builtin/repack.c: rename various pack_geometry functions
Message-ID: <aNsUnfRPi8cYwGkm@pks.im>
In-Reply-To: <dd67366476172eb1b5b0d2bb2a4dfe92b96b83ba.1759097191.git.me@ttaylorr.com>

On Sun, Sep 28, 2025 at 06:08:54PM -0400, Taylor Blau wrote:
> diff --git a/builtin/repack.c b/builtin/repack.c
> index 18c3df7200..2ce1ae3364 100644
> --- a/builtin/repack.c
> +++ b/builtin/repack.c
> @@ -115,17 +115,17 @@ struct pack_geometry {
>  	int split_factor;
>  };
>  
> -static uint32_t geometry_pack_weight(struct packed_git *p)
> +static uint32_t pack_geometry_weight(struct packed_git *p)

This rename is a bit of an oddball as we don't work on a `struct
pack_geometry` here.

> @@ -332,7 +332,7 @@ static void geometry_remove_redundant_packs(struct pack_geometry *geometry,
>  	strbuf_release(&buf);
>  }
>  
> -static void free_pack_geometry(struct pack_geometry *geometry)
> +static void pack_geometry_release(struct pack_geometry *geometry)
>  {
>  	if (!geometry)
>  		return;

Okay, this function also gets adjusted for the new naming schema we have
around free/release. Good, but it might be worth it to point it out in
the commit message.

Patrick