From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 29 Sep 2025 23:21:28 GMT
Subject: Re: [PATCH 12/49] builtin/repack.c: pass both pack_objects args to repack_config
Message-ID: <aNsUeH2HudfxIQsx@pks.im>
In-Reply-To: <75386eed60c80a52c42720e4918853ff05c5584c.1759097191.git.me@ttaylorr.com>

On Sun, Sep 28, 2025 at 06:07:56PM -0400, Taylor Blau wrote:
> diff --git a/builtin/repack.c b/builtin/repack.c
> index 6dfcb3327e..af6de8d77a 100644
> --- a/builtin/repack.c
> +++ b/builtin/repack.c
> @@ -1260,6 +1266,7 @@ int cmd_repack(int argc,
>  	size_t midx_pack_names_nr = 0;
>  
>  	/* variables to be filled by option parsing */
> +	struct repack_config_ctx config_ctx;
>  	int delete_redundant = 0;
>  	const char *unpack_unreachable = NULL;
>  	int keep_unreachable = 0;
> @@ -1343,7 +1350,11 @@ int cmd_repack(int argc,
>  
>  	list_objects_filter_init(&po_args.filter_options);
>  
> -	repo_config(repo, repack_config, &cruft_po_args);
> +	memset(&config_ctx, 0, sizeof(config_ctx));
> +	config_ctx.po_args = &po_args;
> +	config_ctx.cruft_po_args = &cruft_po_args;
> +
> +	repo_config(repo, repack_config, &config_ctx);

Nit: same comment here as on a previous commit, we could use a
designated initializer here.

Patrick