From: Patrick Steinhardt Date: Tue, 23 Sep 2025 05:11:24 GMT Subject: Re: [PATCH v2 00/18] Introduce rust: In xdiff Message-ID: In-Reply-To: On Mon, Sep 22, 2025 at 10:27:32AM -0600, Ezekiel Newren wrote: > On Mon, Sep 22, 2025 at 10:16 AM Patrick Steinhardt wrote: > > On Mon, Sep 22, 2025 at 09:18:14AM -0600, Ezekiel Newren wrote: > > > > By the way: I'm also happy to change attribution of some of the patches > > > > in my patch series to mention Ezekiel as author. I don't care much who > > > > is listed for the initial patches that introduce Rust, but would retain > > > > my own authorship for the "varint" and "BreakingChanges" commits. > > > > > > My only other concern is with varint. You use usize on the Rust side > > > and then uint64_t on the C side, but I'm ok with fixing that later as > > > it only breaks 'linux32 (i386/ubuntu:focal)' in the github workflows. > > > > Oh, this is actually an oversight, good catch! I refactored "varint.c" > > to use `uint64_t`, but then forgot to adjust the Rust side in the same > > spirit. Will fix. > > You also missed updating varint.h. Hm, am I missing anything? It does use `uint64_t`, and if it didn't it would cause a compiler error due to mismatching declarations. > > I suggested in [1] that I can change authorship of the patches that > > introduce the initial infrastructure into Meson and our Makefile (so I > > guess patches 1 and 3) to instead list you as author and myself as > > Co-authored-by. Is that something you want? Given that you have > > kickstarted the whole effort around introducing Rust again I wouldn't > > mind that at all. > > It doesn't make sense to me to list myself as the author of any of > your commits, but I would like my name referenced in your commit > messages. Okay, will do. Is it sufficient if I say something "Based-on-patch-by" or "Inspired-by"? Don't really have much of a better idea for how to include it, but please let me know in case you have any preference. Patrick