From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 03 Sep 2025 12:20:13 GMT
Subject: Re: [PATCH RFC v2 16/16] builtin/history: implement "reword" subcommand
Message-ID: <aLgyfZEmjDAYewaV@pks.im>
In-Reply-To: <5079326d-497c-4335-88d0-a248e0b8c6d1@app.fastmail.com>

On Sun, Aug 24, 2025 at 08:08:07PM +0200, Kristoffer Haugsbakk wrote:
> On Sun, Aug 24, 2025, at 19:42, Patrick Steinhardt wrote:
> > Implement a new "reword" subcommand for git-history(1). This subcommand
> > is essentially the same as if a user performed an interactive rebase
> > with a single commit changed to use the "reword" verb.
> >
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>
> 
> I get a “split” error when I typo the commit to reword:
> 
>     $ ./git history reword ./s2
>     error: commit to be split cannot be found: ./s2

Oh, indeed, this is a boring copy-paste error:

diff --git a/builtin/history.c b/builtin/history.c
index cdc93a1cbd..f03272bddd 100644
--- a/builtin/history.c
+++ b/builtin/history.c
@@ -749,7 +749,7 @@ static int cmd_history_reword(int argc,
 
 	original_commit = lookup_commit_reference_by_name(argv[0]);
 	if (!original_commit) {
-		ret = error(_("commit to be split cannot be found: %s"), argv[0]);
+		ret = error(_("commit to be reworded cannot be found: %s"), argv[0]);
 		goto out;
 	}

Thanks for noticing!

Patrick