From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 03 Sep 2025 11:51:16 GMT
Subject: Re: [PATCH 6/6] breaking-changes: switch default branch to main
Message-ID: <aLgrtLtqTnSOatTD@pks.im>
In-Reply-To: <9d52f24e-d495-44d4-b122-7d80d1f4b77f@gmail.com>

On Wed, Sep 03, 2025 at 10:54:06AM +0100, Phillip Wood wrote:
> On 03/09/2025 05:44, Patrick Steinhardt wrote:
> > Tests should be agnostic of that name and use e.g. git-symbolic-ref(1)
> > to figure out what HEAD points to. So maybe we should follow through
> > with that idea and start refactoring tests into this direction so that
> > they never set or read the variable in the first place.
> 
> That might be a good direction for the future. The test suite could set
> TEST_DEFAULT_BRANCH to the default name and tests could use that rather
> setting GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME and hard coding the expected
> name or running 'git symbolic-ref'.
> 
> I'll drop the removal of GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME but I'd like
> to keep the patches that switch the tests from using "master" to "main".
> We've converted nearly all of the tests already so it seems a shame to leave
> a handful unconverted.

Fair enough.

Patrick