From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 03 Sep 2025 10:15:27 GMT
Subject: Re: [PATCH v2 5/6] midx-write: reenable signed comparison errors
Message-ID: <aLgVPx5gOI9ZIRu_@pks.im>
In-Reply-To: <35302f52285d98c3e7ed7ab4140b4721375bc8a3.1756589007.git.gitgitgadget@gmail.com>

On Sat, Aug 30, 2025 at 09:23:26PM +0000, Derrick Stolee via GitGitGadget wrote:
> diff --git a/midx-write.c b/midx-write.c
> index 1822268ce2..14a0947c46 100644
> --- a/midx-write.c
> +++ b/midx-write.c
> @@ -1430,6 +1428,9 @@ static int write_midx_internal(struct repository *r, const char *object_dir,
>  	 * have been freed in the previous if block.
>  	 */
>  
> +	if (ctx.num_multi_pack_indexes_before == UINT32_MAX)
> +		die("too many multi-pack-indexes");
> +
>  	CALLOC_ARRAY(keep_hashes, ctx.num_multi_pack_indexes_before + 1);
>  
>  	if (ctx.incremental) {

Should this error message be translated?

Everything else in this commit looks good to me. Thanks for cleaning
these up.

Patrick